Update README.md for v0.2.0 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikurube
force-pushed
the
README-v0.2.0
branch
4 times, most recently
from
c024f83
to
b96947d
Compare
hiroyuki-sato
approved these changes
Jun 12, 2024
|
|
||
| artifact "org.embulk:embulk-input-postgresql:0.13.2" | ||
| artifact group: "org.embulk", name: "embulk-input-s3", version: "0.6.0" | ||
|
|
||
| // It downloads jruby-complete-9.1.15.0.jar, and set the "jruby" Embulk System Property in "embulk.properties". |
There was a problem hiding this comment.
Minor Adding the location of download JRuby file may useful. what do you think?
There was a problem hiding this comment.
Adding some explanation in README? Or as a kind of feature?
There was a problem hiding this comment.
It meant in README.
// JRuby install in the xxx directoryThere was a problem hiding this comment.
The path would be written in embulk.properties. I do not want to make it "documented" because documenting it would chain our future changes.
|
Thanks anyway! Let me merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.