Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for v0.2.0 #24

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update README.md for v0.2.0 #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,26 @@ Set up Gradle 8.7 or later, and make `build.gradle` like below.

```
plugins {
id "org.embulk.runset" version "0.1.0" // Just apply this Gradle plugin.
id "org.embulk.runset" version "0.2.0" // Just apply this Gradle plugin.
}

repositories {
mavenCentral()
}

installEmbulkRunSet {
embulkHome file("path/to/embulk-home") // Set your Embulk home directory (absolute path) to install the Embulk plugins.
// Set your Embulk home directory (absolute path) to install the Embulk plugins and "embulk.properties".
embulkHome file("/path/to/your-embulk-home")

artifact "org.embulk:embulk-input-postgresql:0.13.2"
artifact group: "org.embulk", name: "embulk-input-s3", version: "0.6.0"

// It downloads jruby-complete-9.1.15.0.jar, and set the "jruby" Embulk System Property in "embulk.properties".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Adding the location of download JRuby file may useful. what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some explanation in README? Or as a kind of feature?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It meant in README.

// JRuby install in the xxx directory

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path would be written in embulk.properties. I do not want to make it "documented" because documenting it would chain our future changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, Thanks!

jruby "org.jruby:jruby-complete:9.1.15.0"

// It sets the "key" Embulk System Property to "value" in "embulk.properties".
embulkSystemProperty "key", "value"
}
```

Run `./gradlew installEmbulkRunSet`, then.
Run `./gradlew installEmbulkRunSet`, then the plugins and "embulk.properties" are set up in the `embulkHome` directory.
Loading