Specify "embulkHome" instead of "into" in InstallEmbulkRunSet #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikurube
force-pushed
the
specify-embulkHome-instead-of-into
branch
from
a287291
to
14ac48a
Compare
dmikurube
force-pushed
the
specify-embulkHome-instead-of-into
branch
2 times, most recently
from
d5ad77a
to
06b8bd3
Compare
dmikurube
force-pushed
the
specify-embulkHome-instead-of-into
branch
from
06b8bd3
to
d0a71a0
Compare
dmikurube
force-pushed
the
specify-embulkHome-instead-of-into
branch
from
d0a71a0
to
2008df8
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Gradle plugin intends to "set up" all files under the Embulk Home, not only Maven artifacts, but also
embulk.propertiesand else.Just reusing the existing
into(inCopy) is not good. We'll want it to be explicitembulkHome.