Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ld select optgroup #902

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Feat/ld select optgroup #902

merged 3 commits into from
Aug 29, 2023

Conversation

borisdiakur
Copy link
Contributor

Description

This PR includes the ld-optgroup feature.

Resolves #879

Type of change

  • Feature

Is it a breaking change?

  • No

How Has This Been Tested?

  • unit tests
  • e2e tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Aug 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 0:47am

@borisdiakur borisdiakur force-pushed the feat/ld-select_optgroup branch from d62de60 to 0d5fd4f Compare August 25, 2023 21:00
@borisdiakur borisdiakur marked this pull request as draft August 25, 2023 21:36
@borisdiakur borisdiakur force-pushed the feat/ld-select_optgroup branch from 0d5fd4f to 71e845e Compare August 25, 2023 21:47
@borisdiakur borisdiakur marked this pull request as ready for review August 25, 2023 21:47
@borisdiakur borisdiakur marked this pull request as draft August 25, 2023 21:54
@borisdiakur borisdiakur force-pushed the feat/ld-select_optgroup branch from 71e845e to 800af43 Compare August 25, 2023 22:02
@borisdiakur borisdiakur force-pushed the feat/ld-select_optgroup branch from 800af43 to 0a5d6f7 Compare August 25, 2023 22:17
@borisdiakur borisdiakur marked this pull request as ready for review August 25, 2023 22:18
@borisdiakur borisdiakur requested a review from renet August 28, 2023 07:30
renet
renet requested changes Aug 28, 2023
View reviewed changes
src/liquid/components/ld-select/ld-optgroup-internal/ld-optgroup-internal.shadow.css Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-optgroup-internal/ld-optgroup-internal.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-optgroup/ld-optgroup.shadow.css Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-optgroup/ld-optgroup.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-option-internal/ld-option-internal.shadow.css Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Show resolved Hide resolved
@borisdiakur borisdiakur requested a review from renet August 29, 2023 10:30
@borisdiakur borisdiakur force-pushed the feat/ld-select_optgroup branch from b8953c1 to 161004a Compare August 29, 2023 12:43
@borisdiakur borisdiakur merged commit 71870e3 into main Aug 29, 2023
7 checks passed
@borisdiakur borisdiakur deleted the feat/ld-select_optgroup branch August 29, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renet renet renet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: grouping feature to the Select component
2 participants
@borisdiakur @renet