Fix unintended renamings and formatting

CHANGELOG.md

@@ -23,8 +23,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - `Recommender`s now share their core logic via their base class
 - Remove progress bars in examples
-- Strategies are now called `MetaRecommender`'s and part of the recommenders.meta module
-- `Recommender`'s are now called `PureRecommender`'s and part of the recommenders.pure
+- Strategies are now called `MetaRecommender`'s and part of the `recommenders.meta`
+  module
+- `Recommender`'s are now called `PureRecommender`'s and part of the `recommenders.pure`
   module
 - `strategy` keyword of `Campaign` renamed to `recommender`
 - `NaiveHybridRecommender` renamed to `NaiveHybridSpaceRecommender`

baybe/acquisition.py

@@ -111,7 +111,7 @@ class PartialAcquisitionFunction:
     pinned_part: Tensor
     """The values that will be attached whenever evaluating the acquisition function."""
 
-    pin_discrete: Tensor
+    pin_discrete: bool
     """A flag for denoting whether ``pinned_part`` corresponds to the discrete
     subspace."""
 

baybe/campaign.py

@@ -45,7 +45,7 @@ class Campaign(SerialMixin):
     In particular, a campaign:
         * Defines the objective of an experimentation process.
         * Defines the search space over which the experimental parameter may vary.
-        * Defines a recommender for traversing the search space.
+        * Defines a recommender for exploring the search space.
         * Records the measurement data collected during the process.
         * Records metadata about the progress of the experimentation process.
     """
@@ -100,8 +100,8 @@ def _validate_strategy(self, _, value) -> None:
         """Raise a DeprecationError if the strategy attribute is used."""
         if value is not None:
             raise DeprecationError(
-                "Passing 'strategy' to the constructor is deprecated. The attribute"
-                " has been renamed to 'recommender'"
+                "Passing 'strategy' to the constructor is deprecated. The attribute "
+                "has been renamed to 'recommender'."
             )
 
     @property

baybe/parameters/base.py

@@ -61,7 +61,7 @@ class DiscreteParameter(Parameter, ABC):
 
     # class variables
     encoding: Optional[ParameterEncoding] = field(init=False, default=None)
-    """An optional encoding recommender for the parameter."""
+    """An optional encoding for the parameter."""
 
     @property
     @abstractmethod

baybe/simulation.py

@@ -3,7 +3,7 @@
 The term "simulation" can have two slightly different interpretations, depending on the
 applied context:
 
-*   It can refer to "backtesting" a particular DOE recommender on a fixed (finite)
+*   It can refer to "backtesting" a particular DOE strategy on a fixed (finite)
     dataset. In this context, "simulation" means investigating what experimental
     trajectory we would have observed if we had applied the recommender in a certain
     defined context and restricted the possible parameter configurations to those
@@ -492,7 +492,7 @@ def simulate_experiment(
             measured = campaign.recommend(batch_size=batch_size)
         except NotEnoughPointsLeftError:
             # TODO: There can be still N < batch_quantity points left in the search
-            #   space. Once the recommender/recommender refactoring is completed,
+            #   space. Once the recommender/strategy refactoring is completed,
             #   find an elegant way to return those.
             warnings.warn(
                 "The simulation of the campaign ended because because not sufficiently "

mypy.ini

@@ -3,8 +3,7 @@ packages = baybe
 
 ; at some point, these excludes should all be gone ...
 exclude = (?x)(
-          baybe/recommenders
-          | baybe/searchspace
+          baybe/searchspace
           | baybe/serialization
           | baybe/strategies
           | baybe/surrogates

tests/test_deprecations.py

@@ -41,7 +41,7 @@ def test_renamed_surrogate():
         from baybe.surrogate import GaussianProcessSurrogate  # noqa: F401
 
 
-def test_missing_strategy_type(config):
+def test_missing_recommender_type(config):
     """Specifying a recommender without a corresponding type raises a warning."""
     dict_ = json.loads(config)
     dict_["recommender"].pop("type")