-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor visual issues in the documentation #195
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@Scienfitz the |
@AVHopp thats right I thought I still saw progress bars somewhere but it seems theyre gone and I probably confused some of the cache notifications with them |
This comment was marked as duplicate.
This comment was marked as duplicate.
Would definitely be nice to have some indication of how far along the search is though! Curious why this was removed? |
@brandon-holt this Issue is just about the documentation, where progress bars have been removed. The progress bars when using our simulation module should still be there |
@Scienfitz In the Simulation section, the section for simulate_experiment contains a codeblock for simulate scenarios: Also, the codeblocks used don't make certain aspects of usage clear. For example, for the campaign variable, do we need to define a searchspace, or will the searchspace be automatically generated from initial_data? Or, if we use the DataFrame option for the lookup variable, is that not the same dataframe as for initial_data? |
@brandon-holt thanks for spotting that! technically your points are not visual but about a bug and content suggestions, so we should not discuss these in this thread. Would you be open to make s small PR fixing the code snippet? The respective .md file is in As for the searchspace question: Nothing is inferred from |
@Scienfitz Just made the PR! Also, disregard my question about searchspace/initial_data I understand now! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Since the question came up in #347 : Some of the errors mentioned here are fixed in #347 , some things I do not know how to fix (like changing the name of |
This PR fixes the displayed math in the docstring of the CardinalityConstraint class (see #195 ).
This issue is intended to serve as a place where minor visual issues regarding the documentation can be collected. Once enough such have been identified, they will be resolved in a corresponding PR.
Note in particular that this issue should not be used to collect major changes. Basically, if you see something in our documentation and think "Huh, that just looks a bit weird and would benefit from reformatting", then this is the place to just put it 😄
EDIT: The following issues have been identified:
baybe
in the table of contents (NOTE: I do not think that this is possible, putting this here nevertheless)The following issues have already been fixed:
The text was updated successfully, but these errors were encountered: