Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visuals in examples #347

Merged
merged 24 commits into from
Sep 6, 2024
Merged

Fix visuals in examples #347

merged 24 commits into from
Sep 6, 2024

Conversation

AVHopp
Copy link
Collaborator

@AVHopp AVHopp commented Aug 22, 2024

This PR fixes all of the visual issues that we currently have in the examples. This includes

  • Fixing deprecated mechanisms that were still being used
  • Changing the format of of __str__ representations to avoid messing up when converting to notebook
  • Adding several missing __str__ representations
  • Adding an indent function for indentation within __str__ representations.

To verify, just build the documentation locally and go through the examples.

@AVHopp AVHopp added the documentation Improvements or additions to documentation label Aug 22, 2024
@AVHopp AVHopp self-assigned this Aug 22, 2024
@Scienfitz
Copy link
Collaborator

@AVHopp are any of the doc/example pages still showing the caching? Because something that I wanted to suggest to being added is to run all of the docs/example building with caching turned off so the output doesnt disturb the pages

see https://emdgroup.github.io/baybe/userguide/envvars.html#disk-caching

examples/Serialization/basic_serialization.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
baybe/campaign.py Outdated Show resolved Hide resolved
baybe/objectives/desirability.py Outdated Show resolved Hide resolved
baybe/utils/dataframe.py Show resolved Hide resolved
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AVHopp, here a few comments/questions.

examples/Constraints_Continuous/linear_constraints.py Outdated Show resolved Hide resolved
examples/Serialization/basic_serialization.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/surrogates/gaussian_process/core.py Outdated Show resolved Hide resolved
baybe/surrogates/gaussian_process/core.py Show resolved Hide resolved
baybe/searchspace/discrete.py Outdated Show resolved Hide resolved
baybe/surrogates/gaussian_process/core.py Outdated Show resolved Hide resolved
@Scienfitz
Copy link
Collaborator

@AVHopp I notice this one is still open on almost the same topic #195 When do we plan to stop collecting and start fixing those?

baybe/campaign.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
baybe/surrogates/random_forest.py Outdated Show resolved Hide resolved
baybe/campaign.py Outdated Show resolved Hide resolved
@AVHopp AVHopp force-pushed the doc/example_visual_fixes branch 2 times, most recently from ae63fdf to d4d6613 Compare September 5, 2024 15:44
baybe/surrogates/custom.py Outdated Show resolved Hide resolved
baybe/utils/plotting.py Outdated Show resolved Hide resolved
@AVHopp AVHopp merged commit 9b14604 into main Sep 6, 2024
10 of 11 checks passed
@AVHopp AVHopp deleted the doc/example_visual_fixes branch October 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants