Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy for recommenders #147

Merged
merged 13 commits into from
Feb 28, 2024
Merged

Mypy for recommenders #147

merged 13 commits into from
Feb 28, 2024

Conversation

Scienfitz
Copy link
Collaborator

this is based on PR #146

This fixes types in the recommender package
except:

  • assignment errors which cannot currently be solved as we explicitly expect an error if a recommender that cannot handle 0 data is used, this will be fixed once thats enabled for the bayesian one

@Scienfitz Scienfitz added the typing Typing related things label Feb 27, 2024
@Scienfitz Scienfitz self-assigned this Feb 27, 2024
Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments, looks mostly gucci for me. Already approving to avoid blocking, but I'd appreciate if you'd ping me if the other PR is merged such that I can potentially have another look.

baybe/recommenders/meta/sequential.py Show resolved Hide resolved
baybe/recommenders/naive.py Show resolved Hide resolved
baybe/recommenders/pure/bayesian/base.py Outdated Show resolved Hide resolved
baybe/recommenders/pure/bayesian/base.py Show resolved Hide resolved
@Scienfitz Scienfitz merged commit 2277118 into main Feb 28, 2024
10 checks passed
@Scienfitz Scienfitz deleted the mypy/recommenders branch February 28, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Typing related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants