Improve FPS #336
Merged
Improve FPS #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
reviewed
Aug 8, 2024
AdrianSosic
force-pushed
the
refactor/fps
branch
from
68f8645
to
6607c5e
Compare
AVHopp
approved these changes
Aug 9, 2024
Merged
AdrianSosic
force-pushed
the
refactor/fps
branch
from
23d9bc0
to
ed960a4
Compare
AdrianSosic
added a commit
that referenced
this pull request
Sep 3, 2024
This PR adds code to: * sort the user-provided values before storing them as attributes in discrete parameters (see also #336) * sort the parameters stored in search spaces If unsorted, this can cause problems with reproducibility in the sense that the same parameter content provided in a different order can lead to different optimization results. For instance, the `RandomRecommender` randomly selects rows from the `comp_rep` dataframe for the discrete subspace, which will be ordered differently if the parameter values come in a different order. This can lead to rather surprising behavior, like in situations when the parameter values are given as the output of Python's `set` function, whose order depends on `PYTHONHASHSEED`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the
0.10.0release, it was noticed that the optimization results can depend on the order of substances provided by the user if aSubstanceParameteris involved. While the problem is still partly open (see #341), investigation showed that also theFPSRecommendercan yield different results when provided the same set of points in a different order.This PR improves the FPS code in that: