Hypothesis for targets and intervals #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
approved these changes
Dec 11, 2023
AdrianSosic
force-pushed
the
hypothesis/targets
branch
from
979503b to
e6dd01d
Compare
AdrianSosic
commented
Dec 18, 2023
Scienfitz
approved these changes
Dec 18, 2023
The strategies are only meant to span the space of possibilities, without considering alternative ways of object creation. These alternatives are now explicitly triggered in separate test modules.
AdrianSosic
force-pushed
the
hypothesis/targets
branch
from
3263f16 to
86720b4
Compare
AdrianSosic
force-pushed
the
hypothesis/targets
branch
from
904eea0 to
70e8236
Compare
AVHopp
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings hypothesis testing for targets and intervals and follows the same approach as described in #6.
To do so, it also enables proper deserialization of target subclasses via the base class using the same "tagged union approach" as for the remaining BayBE components. Since providing type specification for targets was not enforced previously, a temporary backward-compatible workaround is added that fills missing type.