Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename chain id #300

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Rename chain id #300

merged 3 commits into from
Nov 6, 2018

Conversation

r8d8
Copy link
Contributor

@r8d8 r8d8 commented Nov 2, 2018 •
edited
Loading

@ghost ghost assigned r8d8 Nov 2, 2018
@ghost ghost added the review label Nov 2, 2018
@splix
Copy link
Member

splix commented Nov 2, 2018

I'm wondering, what will happen if a user will try to specify just usual mainnet?

@r8d8
Copy link
Contributor Author

r8d8 commented Nov 4, 2018

Will get invalid argument error, as it's not obvious what does he mean.

@splix
Copy link
Member

splix commented Nov 4, 2018

it shouldn't be error, It should run mainnet. Same as geth

@r8d8 r8d8 requested review from whilei, splix and tzdybal November 5, 2018 14:39
@r8d8 r8d8 merged commit 743c856 into emeraldpay:master Nov 6, 2018
@ghost ghost removed the review label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splix splix splix approved these changes

@whilei whilei whilei approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal

Assignees

@r8d8 r8d8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r8d8 @splix @whilei