webdav: add size to FileSystem.Create() #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
force-pushed
the
feat/create-size
branch
from
9965401 to
f3024c0
Compare
|
Hm right… I think the use-case is reasonable, but backends should keep in mind that the size is just a hint, it may be unset (-1). Also, HTTP compression (Content-Encoding) will always leave Content-Length unset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the total size is necessary upfront to perform the upload to an external system.
And even if not it is good to have it as a minimal test to see if data was transmitted completely ....
Open question:
how to address other valuable headers like checksums or what ever ....
maybe we pass the full request object to Create()?
Or body + headers?
@emersion any objections/idea?