Update PMIC and IMU interrupt handlers to be like FreeRTOS examples #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples of xEventGroupSetBitsFromISR() in event_groups.h and http://www.freertos.org/xEventGroupSetBitsFromISR.html
|
@dpslwk Shall we merge this? You're probably in the best position to judge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull is more for comment & review rather than a firm pull request. I have no previous experience with FreeRTOS but the current code seems inconsistent with the examples of xEventGroupSetBitsFromISR() in event_groups.h and http://www.freertos.org/xEventGroupSetBitsFromISR.html
I have been wondering whether the PMIC is responsible for some lockups because the USB serial debug occasionally reports a flood of charge state changes. Perhaps there is noise on the MCP_STAT line or maybe the battery charger is oscillating between the charging and non-charging states as the dynamic CPU power usage effects the battery voltage.