Merge pull request #18 from atarime/fix-outputs

Fix outputs
emic · Nov 28, 2024 · 5ee5e96 · 5ee5e96
2 parents ce80941 + f9cfa65
commit 5ee5e96
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/admin/class-datasources.php b/admin/class-datasources.php
@@ -109,10 +109,10 @@ public function add_submenu() {
 	 * Display sub menu
 	 */
 	public function display_submenu() {
-		echo sprintf(
+		printf(
 			'<div class="wrap"><h1>%s</h1><p><a href="%s" target="_blank" rel="noopener">%s</a></p></div>',
 			esc_html__( 'Documentation', 'fmpress-forms' ),
-			esc_attr( 'https://github.com/emic/fmpress-forms/wiki' ),
+			esc_url( 'https://github.com/emic/fmpress-forms/wiki' ),
 			esc_html__( 'Click here for documentation.', 'fmpress-forms' )
 		);
 	}
@@ -182,7 +182,7 @@ public function add_datasource_fields() {
 		);
 
 		// Datasource name.
-		echo sprintf(
+		printf(
 			'<div class="form-field">' .
 			'<label for="%1$s">%2$s</label>' .
 			'<input id="%1$s" type="%5$s" name="%3$s" value="%4$s">' .
@@ -195,7 +195,7 @@ public function add_datasource_fields() {
 		);
 
 		// Username.
-		echo sprintf(
+		printf(
 			'<div class="form-field">' .
 			'<label for="%1$s">%2$s</label>' .
 			'<input id="%1$s" type="%5$s" name="%3$s" value="%4$s">' .
@@ -208,7 +208,7 @@ public function add_datasource_fields() {
 		);
 
 		// Password.
-		echo sprintf(
+		printf(
 			'<div class="form-field">' .
 			'<label for="%1$s" data-labelforserver="%13$s" data-labelforcloud="%14$s">%2$s</label>' .
 			'<button id="%8$s" type="button" class="button wp-generate-pw hide-if-no-js" data-labelforserver="%15$s" data-labelforcloud="%16$s">%6$s</button>' .
@@ -440,7 +440,7 @@ private function show_connection_test() {
 			return;
 		}
 
-		echo sprintf(
+		printf(
 			'<button id="connectionTest" class="button">%1$s</button>',
 			esc_html__( 'Connection test', 'fmpress-forms' )
 		);

diff --git a/admin/class-settings.php b/admin/class-settings.php
@@ -206,7 +206,7 @@ private function generate_options_from_custom_post( $saved_value ) {
 	 * @param array $tab Tab array.
 	 */
 	public function add_tab( $tab ) {
-		echo sprintf(
+		printf(
 			'<li class="%s"><span class="%s" style="%s"></span><a href="%s">%s</a></li>',
 			esc_attr( $tab['selected'] ? 'tabs' : 'hide-if-no-js' ),
 			esc_attr( $tab['icon_classes'] ),
@@ -282,7 +282,7 @@ public function add_datasource_id_field( $field_name, $saved_value ) {
 	 * @param string $saved_value .
 	 */
 	public function add_layout_name_field( $field_name, $saved_value ) {
-		echo sprintf(
+		printf(
 			'<tr>' .
 			'<th><label for="%1$s">%2$s</label></th>' .
 			'<td><input id="%1$s" type="%5$s" name="%3$s" value="%4$s"></td>' .