Skip to content

Commit

Permalink
rapidjson: disable tests which fail to compile (NixOS#355633)
Browse files Browse the repository at this point in the history
  • Loading branch information
emilazy committed Nov 17, 2024
2 parents af8fd59 + f868e35 commit a888e34
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
22 changes: 22 additions & 0 deletions pkgs/by-name/ra/rapidjson/char_traits-clang-19-errors.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/test/unittest/writertest.cpp b/test/unittest/writertest.cpp
index 4c24121..66c9087 100644
--- a/test/unittest/writertest.cpp
+++ b/test/unittest/writertest.cpp
@@ -386,6 +386,9 @@ TEST(Writer, InvalidEncoding) {
writer.EndArray();
}

+
+ // does not compile on clang-19
+#if 0
// Fail in encoding
{
StringBuffer buffer;
@@ -401,6 +404,7 @@ TEST(Writer, InvalidEncoding) {
static const UTF32<>::Ch s[] = { 0x110000, 0 }; // Out of U+0000 to U+10FFFF
EXPECT_FALSE(writer.String(s));
}
+#endif
}

TEST(Writer, ValidateEncoding) {
4 changes: 4 additions & 0 deletions pkgs/by-name/ra/rapidjson/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ stdenv.mkDerivation (finalAttrs: {
./use-nixpkgs-gtest.patch
# https://github.com/Tencent/rapidjson/issues/2214
./suppress-valgrind-failures.patch

# disable tests which don't build on clang-19
# https://github.com/Tencent/rapidjson/issues/2318
./char_traits-clang-19-errors.diff
];

postPatch = ''
Expand Down

0 comments on commit a888e34

Please sign in to comment.