fix: [#189] Fix .hamlc is unexpectedly processed by JstProcessor #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieujobin
approved these changes
Jul 3, 2024
mathieujobin
reviewed
Jul 3, 2024
|
@voducvu seems like something is broken with sprockets 4 can you please have a look ? |
|
@mathieujobin Sorry, i'm quite busy now. I'll look into it when I have more time. |
|
Depending on which one gets merged first, this PR or #191 may need to be adjusted since there's a conflict. |
|
@mathieujobin please see 3922a3c -- it's an issue with Rack 3 compatibility and makes the CI green. Should I make it as a separate PR? |
mathieujobin
requested changes
Jul 19, 2024
There was a problem hiding this comment.
I assume this was equivalent to #191 but we don't need both right?
I'm surprise to see a merge conflicts between the two.
please open a new PR if what is merged is incomplete.
thanks
|
@mathieujobin it's not equivalent to #191. Please help me merge #192. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate mimetype for .hamlc and .jst.hamlc so that the hamlc is only processed by HamlCoffeeAssets::Transformer and jst.haml is processed by ::HamlCoffeeAssets::Transformer and JstProcessor