Experiment with a new Group container
#4631
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YgorSouza
reviewed
Jun 8, 2024
| #[derive(Clone, Copy, Debug, PartialEq)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))] | ||
| #[must_use = "You should call .show()"] | ||
| pub struct Group { |
There was a problem hiding this comment.
Is Ui::group going to be changed to use this? Or maybe renamed to avoid confusion?
There was a problem hiding this comment.
I don't know yet. This is all very much related to #4634 in that I would like a simple way to create a new Ui which has opt-in support for the new "grouping" behavior of this PR, as well as a frame (like ui.group does).
|
I made the following change on this branch to see if it fixes emilk/egui_plot#15: M crates/egui_plot/src/lib.rs
@@ -723,7 +723,9 @@ impl<'a> Plot<'a> {
ui: &mut Ui,
build_fn: impl FnOnce(&mut PlotUi) -> R + 'a,
) -> PlotResponse<R> {
- self.show_dyn(ui, Box::new(build_fn))
+ Group::new(self.id_source.with("group"))
+ .show(ui, |ui| self.show_dyn(ui, Box::new(build_fn)))
+ .inner
}And it does, so that's nice. |
|
Would this also fix #4039 ? |
yup, but with a frame of nothingness before the content show up
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new sizing pass logic, we can now support centering of a group of widgets, something we couldn't support before.
This needs more work before it would be ready to use though.