Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp plot zoom values to valid range #4695

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Clamp plot zoom values to valid range #4695

merged 4 commits into from
Jun 26, 2024

Conversation

Its-Just-Nans
Copy link
Contributor

#3462 panics when when hit the bound like f64::MAX

This PR "blocks" zoom if to big

Linked to

@Its-Just-Nans Its-Just-Nans changed the title add code plot zoom out max Jun 23, 2024
@Its-Just-Nans Its-Just-Nans marked this pull request as draft June 24, 2024 17:59
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Jun 24, 2024 •
edited
Loading

Zoom is locked but when zoom in, it's not working properly

This bug is already present, so I think this PR is not blocking

@Its-Just-Nans Its-Just-Nans requested a review from emilk June 24, 2024 18:06
@Its-Just-Nans Its-Just-Nans marked this pull request as ready for review June 24, 2024 18:06
emilk
emilk approved these changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk added bug Something is broken egui_plot Related to egui_plot labels Jun 26, 2024
@emilk emilk merged commit 1036e18 into emilk:master Jun 26, 2024
20 of 21 checks passed
@Its-Just-Nans Its-Just-Nans deleted the plot-bound branch June 26, 2024 14:34
@emilk emilk changed the title plot zoom out max Clamp plot zoom values to valid range Jun 26, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@Its-Just-Nans @hacknus
plot zoom out max (emilk#4695)
557ad36 
* Closes <emilk#3462>


emilk#3462 panics when when hit the bound like `f64::MAX` 

This PR "blocks" zoom if to big


Linked to
- comment in
emilk#4637 (comment)
- emilk#3462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui_plot Related to egui_plot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when zooming out a plot too far
2 participants
@Its-Just-Nans @emilk