Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional cases and the egui inspectors to the test_ui_stack example #4992

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

rustbasic
Copy link
Contributor

Improvement: test_ui_stack

@emilk emilk requested a review from abey79 August 26, 2024 07:44
@abey79 abey79 added egui tests Unit tests, regression tests, manual tests, … labels Aug 26, 2024
Copy link
Collaborator

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this lgtm.

tests/test_ui_stack/src/main.rs Outdated Show resolved Hide resolved
@abey79 abey79 changed the title Improvement: test_ui_stack Add additional cases and the egui inspectors to the test_ui_stack example Aug 26, 2024
@rustbasic rustbasic requested a review from abey79 August 26, 2024 13:23
Copy link
Collaborator

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I'm not sure what the CI is on about. Might maybe be fixed by merging master. Anyways, good to merge as soon as ✅

@emilk emilk merged commit b84a1e2 into emilk:master Aug 26, 2024
18 of 20 checks passed
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
…xample (emilk#4992)

Improvement: test_ui_stack

---------

Co-authored-by: Antoine Beyeler <[email protected]>
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…xample (emilk#4992)

Improvement: test_ui_stack

---------

Co-authored-by: Antoine Beyeler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui tests Unit tests, regression tests, manual tests, …
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants