Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rustix 0.38 #57

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Update to rustix 0.38 #57

merged 2 commits into from
Sep 6, 2023

Conversation

chenx97
Copy link
Contributor

@chenx97 chenx97 commented Aug 22, 2023

This upgrade is meant to bring support for mips32r6 and mips64r6, two Tier-3 architectures that have recently got their own target_arch values.

@chenx97
Copy link
Contributor Author

chenx97 commented Aug 23, 2023

@eminence Do these changes look ok to you?

@chenx97
Copy link
Contributor Author

chenx97 commented Aug 24, 2023

@sunfishcode Does the upgrade look good to you?

@chenx97
Copy link
Contributor Author

chenx97 commented Aug 25, 2023

@eminence bitflags' minimum supported rust version is 1.56.0. What should we do now?

@chenx97
Copy link
Contributor Author

chenx97 commented Aug 25, 2023

like, announce 0.3.0 to break rust 1.48?

@chenx97
Copy link
Contributor Author

chenx97 commented Aug 30, 2023

... OMG rustix 0.38 now requires 1.63.0. I'll come back later...

@chenx97
Copy link
Contributor Author

chenx97 commented Sep 1, 2023

Just to provide some context, I'm proposing this upgrade because of this PR. @eminence any thoughts on the bump of MSRV?

@eminence
Copy link
Owner

eminence commented Sep 1, 2023

Hrm. I'm finding it increasingly difficult to maintain old MSRVs, and there's very little guidance in the wider community about best practices.

rustix is such a foundational crate, it'll be brought into very many crate graphs, so I don't really want to stick with 0.37 forever, we'll need to upgrade to 0.38 at some point, even if that involves a MSRV bump.

So I'm thinking that we'll merge this now, but probably hold off on a release for a bit.

The change mentioned in #48 (comment) is probably big enough to warrant a bump to version 0.3.0, so the next terminal-size release will be 0.3.0

@chenx97
Copy link
Contributor Author

chenx97 commented Sep 1, 2023

Glad to know. Thanks.

@eminence eminence merged commit 27a4459 into eminence:master Sep 6, 2023
17 checks passed
@chenx97 chenx97 deleted the rustix-0.38 branch September 6, 2023 02:09
@chenx97 chenx97 mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants