-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rustix 0.38 #57
Conversation
@eminence Do these changes look ok to you? |
@sunfishcode Does the upgrade look good to you? |
@eminence bitflags' minimum supported rust version is 1.56.0. What should we do now? |
like, announce 0.3.0 to break rust 1.48? |
... OMG rustix 0.38 now requires 1.63.0. I'll come back later... |
Hrm. I'm finding it increasingly difficult to maintain old MSRVs, and there's very little guidance in the wider community about best practices. rustix is such a foundational crate, it'll be brought into very many crate graphs, so I don't really want to stick with 0.37 forever, we'll need to upgrade to 0.38 at some point, even if that involves a MSRV bump. So I'm thinking that we'll merge this now, but probably hold off on a release for a bit. The change mentioned in #48 (comment) is probably big enough to warrant a bump to version 0.3.0, so the next |
Glad to know. Thanks. |
This upgrade is meant to bring support for mips32r6 and mips64r6, two Tier-3 architectures that have recently got their own
target_arch
values.