Update the API for I/O safety #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new `terminal_size_of` fuctions which use the `AsFd` and `AsHandle` traits to accept file descriptors (on Unix) and handles (on Windows). Deprecate the existing `terminal_size_using_*` functions which take raw file descriptors or handles without being `unsafe`. And update the `get_size` example to use the new `terminal_size_of` functions. The example can now be much simpler because the main API is now the same between Windows and Unix in common cases.
18 tasks
|
Thanks! I'm sure the code is fine, but I want to take a moment to make sure I understand it. Target for merge and release is sometime next weekend. |
eminence
reviewed
Sep 16, 2024
|
Thanks again for this PR (and for all your work on pushing the I/O safety stuff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
terminal_size_offuctions which use theAsFdandAsHandletraits to accept file descriptors (on Unix) and handles (on Windows).Deprecate the existing
terminal_size_using_*functions which take raw file descriptors or handles without beingunsafe.And update the
get_sizeexample to use the newterminal_size_offunctions. The example can now be much simpler because the main API is now the same between Windows and Unix in common cases.