Auth #13
Open
Auth #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emir
requested changes
Jan 26, 2019
There was a problem hiding this comment.
Email/password kombinasyonu ile kayıt olan kullanıcılara email onayı da gönderelim. https://laravel.com/docs/5.7/verification
| @@ -18,7 +18,8 @@ public function up() | |||
| $table->string('name'); | |||
| $table->string('email')->unique(); | |||
| $table->string('username')->unique(); | |||
| $table->string('github_id')->unique(); | |||
| $table->string('password'); | |||
There was a problem hiding this comment.
@bdemirpolat Burak migration'da herhangi bir değişiklik yapılacağı zaman yeni bir migration oluşturup yapman gerekiyor ki daha önce dotCFP'i kurmuş kişiler etkilenmesin. Örneğin cfp.phpkonf.org'da biz bu migration'ı çalıştırdık ve users tablosuna kayıtlar girildi. Ben yeniden bu migration'ı çalıştırmak için migrate:refresh gibi bir komut verirsem verileri kaybederim. Ama aşağıdaki gibi yeni bir migration oluşturup eklersen yeni eklediğin password alanını da kullanabiliyor olurum.
php artisan make:migration add_password_to_users_table
defaultStringLength issue has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth review.