Add a development section to the README #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiask
force-pushed
the
development-section
branch
from
5314c20 to
4977ff2
Compare
gi0baro
reviewed
Sep 5, 2023
There was a problem hiding this comment.
@matthiask maybe we can suggest to use maturin for local development?
|
Thank you! Sure, I'll look into it, I didn't know that a maturin executable existed until I read the GitHub action workflow file. |
Merged
gi0baro
force-pushed
the
master
branch
4 times, most recently
from
403a2ea to
a0d86e7
Compare
matthiask
force-pushed
the
development-section
branch
from
4977ff2 to
9bb98f9
Compare
|
@gi0baro I have updated the pull request and am now recommending using |
|
@matthiask thank you for the update. Can you clarify on the |
|
I got warnings when it wasn't installed. It seems it's required to build manylinux wheels. I'm a bit confused if it's necessary for development or only for releases, but I sometimes try erring on the side of installing more optional dependencies when warned about them. What do you think? |
gi0baro
force-pushed
the
master
branch
2 times, most recently
from
ff9588a to
1814868
Compare
gi0baro
force-pushed
the
master
branch
3 times, most recently
from
eb5297c to
8f05250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.