Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with Python 3 #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

criptych
Copy link

Python 2 is at end-of-life (today!) and there are (just a few) problems running this script under Python 3. This PR makes most of the changes recommended by 2to3 (replacing urllib2 and adding parens around print arguments) as well as the following style and bugfix changes:

  • Replace optparse (deprecated since 2.7/3.2) with argparse
  • Replace arguments taking a bool parameter with 'store_true'
  • Use self.<method> instead of Class.<method>(self, ...) in PhpSerializer
  • Fix bytes vs string usage (especially for loading signature database)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant