Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/results calculation user feedback #110

Merged
merged 15 commits into from
May 6, 2024

Conversation

bmlancien
Copy link
Contributor

@bmlancien bmlancien commented May 1, 2024

Fixes #95
Fixes #88

I implemented the mockups from #95 without functionality:

  • Added calculation description/loading box at the top of the sidebar
    • .panel-item__calc-alert CSS class for normal loading (green)
    • .panel-item__calc-alert.panel-item__calc-alert--error CSS classes if error (red)
  • Added chart skeletons placeholders with shimmer animation
  • There is now also "Berechnung läuft ..." from last pull from dev, I guess we don't need both the box and this alert at the same time?

The issue from #88 was also a problem here, so I kind of fixed it. I mean kind of, because the arrow of all the tooltips was not placed correctly (you can see this in the screenshot from #88) and I couldn't find a way to fix it, so I decided to simply remove it. I think it works okay. But feel free to check for a solution if you want to. I just didn't want to spend so much time on it as I don't see this as urgent.

@nesnoj

Also, the text should be left-aligned and I'd like to add line breaks - is this easily possible?

  • Now the text should be left-aligned
  • I added the possibility to use HTML elements in the tooltip:

const tooltipList = [...tooltipTriggerList].map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl, {html: true}))

So it should be possible to add <br>

@bmlancien bmlancien requested review from henhuy and nesnoj May 1, 2024 11:34
@bmlancien bmlancien self-assigned this May 1, 2024
Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!
I can see the elements as described, also HTML works now in tooltips.

@henhuy should give this a check too.
Next step is to wire the progress bar and charts to the rest..

@henhuy henhuy force-pushed the feature/results-calculation-user-feedback branch from e304b92 to f00c42c Compare May 6, 2024 10:09
@nesnoj nesnoj marked this pull request as ready for review May 6, 2024 14:57
Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great blinky stuff, cheers!
I commented-out progress bar as it's not wired yet, new issue: #132

@nesnoj nesnoj merged commit 1176586 into dev May 6, 2024
1 check passed
@nesnoj nesnoj deleted the feature/results-calculation-user-feedback branch May 6, 2024 14:58
@nesnoj nesnoj mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout for non-ready charts Tooltip texts from layer legend are sometimes truncated
3 participants