Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/accessibility #146

Merged
merged 16 commits into from
May 22, 2024
Merged

Improve/accessibility #146

merged 16 commits into from
May 22, 2024

Conversation

bmlancien
Copy link
Contributor

@bmlancien bmlancien commented May 15, 2024

Closes #144

@bmlancien bmlancien self-assigned this May 15, 2024
@nesnoj
Copy link
Contributor

nesnoj commented May 16, 2024

Thank you for spotting and this PR @bmlancien! Please go ahead fixing the most important (!) things and I can review as soon as it is ready.

@bmlancien
Copy link
Contributor Author

Alright @nesnoj.

In this PR I mostly did the following:

  • improved keyboard navigation (now the tooltip contents should be visible and selecting a scenario should be possible)
  • added missing aria attributes and aria label descriptions as well as improved HTML5 semantics (useful for navigating the app with screen readers)
  • enabled screen reader description of charts (see documentation). I read that the configurated language will be used to build the description, and I don't think it's the case now, so when it was possible I added a description in German made of the chart's title and legend data.
  • corrected color contrast

I didn't work on making the map more understandable, as this is too much of a process to do it properly. I didn't see any accessibility option directly on the MapLibre page, only this.

There are also some areas where I probably missed things or didn't implement the correct way. For example I was technically not able to link the slider labels to the sliders for the screen readers. I'm also not very sure of how easy it is no navigate with a screen reader on a web app that actually consists of only one page but have different views toggled on and off... But after that PR the accessibility score should - hopefully - be a bit better.

For future tools I would recommend to focus more on the accessibility issue, especially accessibility in data visualization. I will try to gather more knowledge in that field as it is very relevant to the tools developed by the institute. I would also find it interesting to test future tools with users with disabilities to see how good/bad the apps are.

@bmlancien bmlancien marked this pull request as ready for review May 16, 2024 15:12
@nesnoj nesnoj self-requested a review May 17, 2024 11:13
Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @bmlancien for these improvements!

@nesnoj nesnoj merged commit 606d323 into dev May 22, 2024
1 check failed
@nesnoj nesnoj deleted the improve/accessibility branch May 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility can be improved
2 participants