Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update mapengine 2.0.x #166

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Feature/update mapengine 2.0.x #166

merged 8 commits into from
Oct 16, 2024

Conversation

nesnoj
Copy link
Contributor

@nesnoj nesnoj commented Oct 15, 2024

Fixes #165

This

It basically works - can you have a quick look to see if the mapengine update is done properly and I did not miss anything? @henhuy

Also, I encoutered two problems:

  1. The hover effect for the muns is not working anymore - it should look like this:
    image
    However, the associated style region-line in layer_styles.json is used since when I change line-color or the default line width I see the change. Why not the hovering?
  2. Having a WMS layer activated, I get errors in the console when zooming/moving around and could not find out why, maybe you can make more from the message. It does not seem to have any negative effect though.
raster_tile_source.ts:219 Uncaught (in promise) AbortError: signal is aborted without reason
    at $.<anonymous> (raster_tile_source.ts:219:34)
    at Generator.next (<anonymous>)
    at tslib.es6.js:121:71
    at new Promise (<anonymous>)
    at Object.e [as _] (tslib.es6.js:117:12)
    at $.abortTile (raster_tile_source.ts:218:13)
    at ct._abortTile (source_cache.ts:195:26)
    at ct._removeTile (source_cache.ts:867:18)
    at ct.update (source_cache.ts:656:22)
    at ce._updateSources (style.ts:1514:35)

@nesnoj nesnoj added the enhancement 🚀 New feature or request label Oct 15, 2024
@nesnoj nesnoj requested a review from henhuy October 15, 2024 08:12
@nesnoj nesnoj self-assigned this Oct 15, 2024
@henhuy
Copy link
Contributor

henhuy commented Oct 15, 2024

Fixed 1. issue
I already researched for a solution of second issue, but whether could find the reason nor a solution for it - already investigated an hour :(

@nesnoj
Copy link
Contributor Author

nesnoj commented Oct 15, 2024

Fixed 1. issue I already researched for a solution of second issue, but whether could find the reason nor a solution for it - already investigated an hour :(

Thx for fixing the hover! I wasn't ware that MAP_ENGINE_REGIONS is still needed in the new mapengine version.

Sorry for the complications on the 2nd thing :( . I also had a closer look (again), I thing it's sth about the bbox and CRS but let's leave it like this.

Last thing: layer order (z index), temp fix in rl-institut/django-mapengine#20 (comment)

@nesnoj nesnoj merged commit 5adce45 into dev Oct 16, 2024
1 check passed
@nesnoj nesnoj deleted the feature/update_mapengine_2.0.x branch October 16, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to mapengine v2.0.x and add WMS layers
2 participants