Accessibility fixes #112
Open
Accessibility fixes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using swc cuts down the execution time by a factor of 10.
This allows using the lib within a bundler, while still providing an autoloading mechanism for standard usage. Translations are migrated from yaml to ts to simplify the build and import process, as there is no real advantage to using yaml here. The preloading mechanism is removed, as there is a 99% chance that the UI will be shown on a first visit.
Using tsup simplifies and speeds up the process.
`tsup` was generating a custom type for each and every translation object, with all of their properties, resulting in a huge declaration. It turns out that `satisfies` does not impact the output, whereas `as` forces the `Translation` type to be used. We're still keeping the `satisfies` part, as it provides better typechecking (i.e. warning about missing or unknown properties).
* Folded the annotated configuration by default * Added details on theming
* fixed page markup * added missing styles * added a section in the doc
When running a dev server, renaming chunks doesn't work as expected.
HTML elements require dataset props to be camelCased.
When using React 18+, the app must be rendered using createRoot.
Events added by micromodal weren't properly unregistered, causing errors after closing a modal. Also, hiding the banner with `display: none` was preventing focus to be moved back to it after closing the modal.
* harmonized color names * fixed issues when closing modals by clicking the backdrop * fixed focus issue on toggle buttons (using `aria-disabled` instead of `disabled` prevents losing focus when the state changes)
@see RGAA 3.2
@see RGAA 9.3
@see RGAA 12.6
The link's title wasn't valid according to the RGAA. Instead of fixing it, we're removing the link altogether as it is of no real value. @see RGAA 6.1
@see RGAA 9.1
The differenciation was made by color only, there is now also a change in shape. @see RGAA 3.1
@see RGAA 11.5
We're deviating slightly from the official component styles so that buttons appear in the right order. @see https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/gestionnaire-de-consentement @see RGAA 12.8
Most texts were translated automatically from english, pending a better translation. @see RGAA 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.