Implemented GDPR compliant button to enforce accetpance of all apps. … #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Orejime config object updated to enable/disable this feature.
|
any news to merge this feature into master ? |
|
this pr should be quickly merge, the current code poses legal problems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Orejime config object updated to enable/disable this feature.
Currently, Orejime provides a non-useful "accept" button in a GDPR-compliant world. The initial pop-up has an "Accept" button, but this will only accept categories that are set to "Enabled" by default (which is not allowed by GDPR).
So this PR would help fix that by presenting an "Accept all" button (similar to the button on the modal interface behind "Learn More"). It is a configurable feature since it exposes a bool option in the orejime config object so the default behaviour can still remain.