Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin config write guide #2444

Merged
merged 12 commits into from
May 24, 2024

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented May 9, 2024

@JimMoen JimMoen force-pushed the plugin-config-schema-ui branch from 5afbf96 to c1432d0 Compare May 9, 2024 07:35
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add:

  1. Where should the initial config (before EMQX boot) be provided (maybe in the priv dir)
  2. Where are the updated config file stored, (explain overwrite, and the bak files too?)

@JimMoen JimMoen force-pushed the plugin-config-schema-ui branch from 815405c to 27e1b3e Compare May 16, 2024 19:55
Co-authored-by: Zaiming (Stone) Shi <[email protected]>
wivwiv
wivwiv previously approved these changes May 24, 2024
@wivwiv wivwiv dismissed zmstone’s stale review May 24, 2024 06:39

jim says the code is ready, just not the updated documentation. We'll merge it for the release and jim will refine it in a new pr later.

@wivwiv wivwiv merged commit 67f824f into emqx:release-5.7 May 24, 2024
6 checks passed
@JimMoen JimMoen deleted the plugin-config-schema-ui branch May 27, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants