feat: make the metadata of an endpoint be more flexible #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafirest
force-pushed
the
feat/flexible_meta
branch
from
93adcf4 to
0f2284d
Compare
HJianBo
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-13225
In previous versions, the metadata was statically derived from the
authorizemethod, but some endpoints (login, external callback of SSO) may not have anauthorizemethod, or it may be an interactive endpoint whose metadata cannot be determined in one step.Here, the metadata is moved from the function return to the process dictionary, so that the metadata in the endpoint can be updated.