feat: group entity #1199
Draft
feat: group entity #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 12, 2025 16:11
Davidmattei
requested changes
Feb 27, 2025
Davidmattei
reviewed
Mar 3, 2025
Comment on lines
10
to
12
| /** | ||
| * Auto-generated Migration: Please modify to your needs! | ||
| */ |
Davidmattei
requested changes
Mar 3, 2025
| { | ||
| public function getDescription(): string | ||
| { | ||
| return ''; |
Comment on lines
71
to
74
| // dump($this->getClickedButtonName($form)); | ||
| // if (GroupType::DELETE_BUTTON === $this->getClickedButtonName($form)) { | ||
| // dump('c un delete'); | ||
| // } |
Comment on lines
43
to
72
| public function getAliasesName(): array | ||
| { | ||
| // TODO: Implement getAliasesName() method. | ||
| return []; | ||
| } | ||
|
|
||
| public function count(string $searchValue = '', mixed $context = null): int | ||
| { | ||
| // TODO: Implement count() method. | ||
| return 0; | ||
| } | ||
|
|
||
| public function getByItemName(string $name): ?EntityInterface | ||
| { | ||
| return $this->groupRepository->getByName($name); | ||
| } | ||
|
|
||
| public function updateEntityFromJson(EntityInterface $entity, string $json): EntityInterface | ||
| { | ||
| // TODO: Implement updateEntityFromJson() method. | ||
| return $entity; | ||
| } | ||
|
|
||
| public function createEntityFromJson(string $json, ?string $name = null): EntityInterface | ||
| { | ||
| // TODO: Implement createEntityFromJson() method. | ||
| $form = Form::fromJson($json); | ||
|
|
||
| return $form; | ||
| } |
There was a problem hiding this comment.
fix todo's see how other services do it
Comment on lines
84
to
98
|
|
||
| /** | ||
| * @param array<mixed> $routeParams | ||
| */ | ||
| public function addTableToolbarActionDelete(TableAbstract $table, string $route, array $routeParams = []): self | ||
| { | ||
| $table->addToolbarAction( | ||
| label: t('action.delete', [], 'emsco-core'), | ||
| icon: 'fa fa-trash', | ||
| routeName: $route, | ||
| routeParams: $routeParams | ||
| )->setCssClass('btn btn-sm btn-danger'); | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
Why a new toolbar action for delete ? It should work the same as other tables ?
Comment on lines
26
to
28
| public function __construct() | ||
| { | ||
| } |
| ->findOneBy(['name' => $group->getName()]); | ||
|
|
||
| if ($existingGroup) { | ||
| throw new \Exception("Le groupe avec ce nom existe déjà."); |
EMS/core-bundle/src/Routes.php
Outdated
| final public const string GROUP_ADD = 'emsco_group_admin_add'; | ||
| final public const string GROUP_EDIT = 'emsco_group_admin_edit'; | ||
| final public const string GROUP_DELETE = 'emsco_group_admin_delete'; | ||
| final public const string DELETE_ALL_GROUP = 'emsco_group_admin_delete_all_group'; |
There was a problem hiding this comment.
Bad naming DELETE_ALL_GROUP -> GROUP_DELETE_ALL
| {% for user in list_user_group %} | ||
| <li style="display: flex; justify-content: flex-start; align-items: center; margin-bottom: 10px;"> | ||
| {{ user.name }} | ||
| <button class="btn btn-danger" style="margin-left: 10px;">delete</button> |
| {% endfor %} | ||
| </ul> | ||
| <form action="group/add"> | ||
| <button type="submit" class="btn btn-primary" style="margin-left: 5px;">Add group</button> |
|
You should also create a mysql migration, I will give more information |
added 7 commits
March 3, 2025 14:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description for the pull request
developpement de groupe pour centraliser la gestion des roles