Skip to content

Commit

Permalink
Use getSocketAddress helper in __syscall_sendmsg. NFC (#22661)
Browse files Browse the repository at this point in the history
The code here was replicating what `getSocketAddress` was doing.
  • Loading branch information
sbc100 authored Oct 1, 2024
1 parent ea27be2 commit 0962b6c
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/library_syscall.js
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ var SyscallsLibrary = {
}
return -{{{ cDefs.ENOPROTOOPT }}}; // The option is unknown at the level indicated.
},
__syscall_sendmsg__deps: ['$getSocketFromFD', '$readSockaddr', '$DNS'],
__syscall_sendmsg__deps: ['$getSocketFromFD', '$getSocketAddress', '$DNS'],
__syscall_sendmsg: (fd, message, flags, d1, d2, d3) => {
var sock = getSocketFromFD(fd);
var iov = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_iov, '*') }}};
Expand All @@ -451,10 +451,9 @@ var SyscallsLibrary = {
var name = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_name, '*') }}};
var namelen = {{{ makeGetValue('message', C_STRUCTS.msghdr.msg_namelen, 'i32') }}};
if (name) {
var info = readSockaddr(name, namelen);
if (info.errno) return -info.errno;
var info = getSocketAddress(name, namelen);
port = info.port;
addr = DNS.lookup_addr(info.addr) || info.addr;
addr = info.addr;
}
// concatenate scatter-gather arrays into one message buffer
var total = 0;
Expand Down

0 comments on commit 0962b6c

Please sign in to comment.