Skip to content

Commit

Permalink
Use DEPRECATED_SETTINGS for RUNTIME_LINKED_LIBS (#21522)
Browse files Browse the repository at this point in the history
And also for CLOSURE_WARNINGS
  • Loading branch information
sbc100 authored Mar 14, 2024
1 parent 5d1c39d commit cf90417
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
1 change: 0 additions & 1 deletion emcc.py
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,6 @@ def phase_setup(options, state, newargs):
"""

if settings.RUNTIME_LINKED_LIBS:
diagnostics.warning('deprecated', 'RUNTIME_LINKED_LIBS is deprecated; you can simply list the libraries directly on the commandline now')
newargs += settings.RUNTIME_LINKED_LIBS

# Find input files
Expand Down
2 changes: 2 additions & 0 deletions site/source/docs/tools_reference/settings_reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1406,6 +1406,8 @@ RUNTIME_LINKED_LIBS

Deprecated, list shared libraries directly on the command line instead.

.. note:: This setting is deprecated

.. _build_as_worker:

BUILD_AS_WORKER
Expand Down
1 change: 1 addition & 0 deletions src/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -1107,6 +1107,7 @@ var SIDE_MODULE = 0;

// Deprecated, list shared libraries directly on the command line instead.
// [link]
// [deprecated]
var RUNTIME_LINKED_LIBS = [];

// If set to 1, this is a worker library, a special kind of library that is run
Expand Down
2 changes: 2 additions & 0 deletions tools/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@
'SUPPORT_ERRNO': 'emscripten no longer uses the setErrNo library function',
'EXTRA_EXPORTED_RUNTIME_METHODS': 'please use EXPORTED_RUNTIME_METHODS instead',
'DEMANGLE_SUPPORT': 'mangled names no longer appear in stack traces',
'RUNTIME_LINKED_LIBS': 'you can simply list the libraries directly on the commandline now',
'CLOSURE_WARNINGS': 'use -Wclosure instead',
}

# Settings that don't need to be externalized when serializing to json because they
Expand Down

0 comments on commit cf90417

Please sign in to comment.