-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDL2 port to 2.0.22 #16916
Update SDL2 port to 2.0.22 #16916
Conversation
Well, that went badly: |
That error might be an internal problem, as I don't think that function is called directly by user code. Bisecting on emscripten might be a fast way to find where things changed, if its not obvious to you already. cc @tlively who made some recent proxying changes, and might have an idea. |
We reimplemented And that function is called by user SDL code (via a wrapper macro) here: |
This PR will fix #16646 |
I'm guessing library_pthread.c isn't built if you're not using threads? So if (emscripten_is_main_runtime_thread())
do_thing();
else
emscripten_sync_run_in_main_runtime_thread(do_thing); maybe isn't a great idea. (I haven't done much with threads/proxying myself, so don't really know what the right thing to do here is...) |
Probably the simplest thing to do is hide that code behind |
Are we still trying to land this? |
Ah, thanks for the reminder... I think I've fixed this by using This does mean we still can't use a release tag, which was part of the reason for this PR... hmm |
It seems reasonable to continue to use non-released revisions.. at least until we are able to. |
Also adds some more files
Partly undo the previous "fix"
Latest SDL2 dev is 2.23.0
Now passing after a few test adjustments (mouse events again, version number is 2.23.0 instead of 2.0.23) |
Maybe worth adding this to the ChangeLog? |
Update to latest release, includes some threading/proxying improvements.