Don't pass -fvisibility=default unless building with -fPIC. NFC
#21809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Apr 23, 2024
kripken
reviewed
Apr 23, 2024
kripken
approved these changes
Apr 23, 2024
sbc100
force-pushed
the
visibility
branch
2 times, most recently
from
e3890c4
to
6745f44
Compare
This means that, by default, we will get `-fvisibility=hidden` since that is the default in clang when building for wasm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that, by default, we will get
-fvisibility=hiddensince that is the default in clang when building for wasm.