Generate accurate import names in emitDCEGraph #21814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid the receiving code having to attempt to demangle them by removing leading underscore. The other advantage of this method is that allows for JS and native names to differ in other ways (not only the leading underscore). For example, `wasmMemory` vs `memory` and `wasmTable` vs `__indirect_function_table`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid the receiving code having to attempt to demangle them by removing leading underscore.
The other advantage of this method is that allows for JS and native names to differ in other ways (not only the leading underscore). For example,
wasmMemoryvsmemoryandwasmTablevs__indirect_function_table.