Avoid adding hooks for globalThis in MODULARIZE mode #22638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Sep 26, 2024
| // case. | ||
| // | ||
| // In this mode we simply ignore requests for `hookGlobalSymbolAccess`. | ||
| #else |
There was a problem hiding this comment.
To make it clearer why it is valid to ignore here, how about renaming this function to addWarningOnGlobalSymbol? By saying that it is a warning, it is clear that it is optional.
There was a problem hiding this comment.
OK, will do, however all functions in this file are debug only so I think it should fairly clear.
There was a problem hiding this comment.
Ah, good point. In that case lgtm with just a comment here, like "As everything else in this file, these are just debug checks, so we simply avoid them in this case."
sbc100
force-pushed
the
modularize_globalThis
branch
from
9e3bca8
to
17690d4
Compare
|
Yeh, this is probably simplest, rather than trying to codegen the checks. Thanks for thinking about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22588