Fix getaddrinfo for IPv6 loopback address #22640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_getaddrinfo_null
branch
from
730e169
to
7dd821f
Compare
kripken
approved these changes
Sep 26, 2024
| @@ -1073,7 +1073,7 @@ addToLibrary({ | |||
| if (family === {{{ cDefs.AF_INET }}}) { | |||
| addr = _htonl({{{ cDefs.INADDR_LOOPBACK }}}); | |||
| } else { | |||
| addr = [0, 0, 0, 1]; | |||
| addr = [0, 0, 0, _htonl(1)]; | |||
There was a problem hiding this comment.
To make sure I follow, this is an ipv6 address, and line 1074 is ipv4? (hence it is valid for one line to return an int, and other a JS array of 4 ints?)
There was a problem hiding this comment.
Yes, ip4 address are presented as a single number, ip6 is an array of 4 numbers.
This changes makes the address report correctly as ::1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.