Remove unnecessary allowNull argument from getSocketAddress. NFC
#22643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only callsite that was using this third argument was simply doing and early return, we can just most the check to the caller and simpify the code.
sbc100
force-pushed
the
getSocketAddress
branch
from
4e26fb0
to
2de9e96
Compare
brendandahl
reviewed
Sep 27, 2024
brendandahl
approved these changes
Sep 27, 2024
Thats how you can tell its one of mine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only callsite that was using this third argument was simply doing and early return, so we can just move the check to the caller and simplify the code.