Fix missing dependencies in sanitizer builds. NFC #22650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reverts part of emscripten-core#22596. A better fix for this would be to add the missing deps to `--symbols-only` but this change seems like the quickest fix.
sbc100
force-pushed
the
withBuiltinMalloc
branch
from
b0777e2
to
d681687
Compare
dschuff
approved these changes
Sep 27, 2024
|
Checked that the new tests passed, going to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts part of #22596.
A better fix for this would be to add the missing deps to
--symbols-onlybut this change seems like the quickest fix.