Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependencies in sanitizer builds. NFC #22650

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 27, 2024

This change reverts part of #22596.

A better fix for this would be to add the missing deps to --symbols-only but this change seems like the quickest fix.

@sbc100 sbc100 requested a review from dschuff September 27, 2024 16:27
This change reverts part of emscripten-core#22596.

A better fix for this would be to add the missing deps to
`--symbols-only` but this change seems like the quickest fix.
@dschuff dschuff enabled auto-merge (squash) September 27, 2024 16:56
@dschuff dschuff merged commit ceee49d into emscripten-core:main Sep 27, 2024
16 of 28 checks passed
@dschuff
Copy link
Member

dschuff commented Sep 27, 2024

Checked that the new tests passed, going to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants