Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MIN_INT values when checking integer ranges #22664

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix MIN_INT values when checking integer ranges #22664

merged 1 commit into from
Oct 1, 2024
+35 −6

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 1, 2024

Fixes: #19251

@sbc100 sbc100 requested a review from kripken October 1, 2024 19:06
kripken
kripken approved these changes Oct 1, 2024
View reviewed changes
test/core/test_getValue_setValue.cpp Outdated Show resolved Hide resolved
test/test_core.py Outdated Show resolved Hide resolved
@sbc100 sbc100 enabled auto-merge (squash) October 1, 2024 20:24
@sbc100 sbc100 disabled auto-merge October 1, 2024 22:01
@sbc100 sbc100 merged commit 4cb578c into emscripten-core:main Oct 1, 2024
26 of 28 checks passed
@sbc100 sbc100 deleted the fix_int_lmits branch October 1, 2024 22:01
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken