Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website theme for newer Sphinx #15365 #22872
base: main
Are you sure you want to change the base?
Update website theme for newer Sphinx #15365 #22872
Changes from 7 commits
3cd2b9a
52467fb
3686624
ae6aa9f
ae92a88
5b3d2f0
d25fae1
2a2c4ac
8988436
13d674f
162fa7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about if we simply remove all of these dependencies except for the sphinx one ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that
sphinx 7.1.2
hasjinja >= 3.0
as a requirement.I think it's best to keep
jinja2==3.0
to avoid future releases ofjinja2
to break things.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its best to only include direct dependencies here, up until the point where we have some reason to do otherwise.
But i'm no expert so if you think this is safer/better then I'm fine with it.
How about the rest of these indirect deps, can we remove those?