Use struct info in src/library_sdl.js. NFC #22885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
Nov 8, 2024
| @@ -348,13 +348,13 @@ var LibrarySDL = { | |||
| translateRGBAToColor: (r, g, b, a) => r | g << 8 | b << 16 | a << 24, | |||
|
|
|||
| makeSurface(width, height, flags, usePageCanvas, source, rmask, gmask, bmask, amask) { | |||
| var is_SDL_HWSURFACE = flags & 0x00000001; | |||
There was a problem hiding this comment.
It looks like SDL_HWSURFACE constant was wrong here. It should have been 0x08000001. Luckily it was still matching because its a subset of the bits.
kripken
approved these changes
Nov 8, 2024
sbc100
force-pushed
the
sdl_struct_info
branch
from
f821843
to
86ab71f
Compare
sbc100
force-pushed
the
sdl_struct_info
branch
from
86ab71f
to
da709b9
Compare
We have tests at least the keyboard stuff because I made a mistake there and they failed. I double checked everything again and I think we are good now. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 13, 2024
Missed this one in emscripten-core#22885.
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.