Log SDL keyboard events as part of RUNTIME_DEBUG. #22918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I admit this is kind of 3 changes in one, but they are all related. |
sbc100
force-pushed
the
test_sdl_key_test
branch
4 times, most recently
from
e016451
to
0c8a7cf
Compare
sbc100
changed the title
sbc100
force-pushed
the
test_sdl_key_test
branch
from
0c8a7cf
to
196d3f3
Compare
kripken
approved these changes
Nov 13, 2024
Also, test_sdl_key_test.c to test_interactive.py. This test was not being run anywhere else and serves as simple way to test/debug keyboard events. Also, only set the `RUNTIME_DEBUG` default if the user does not explicitly set it themselves. This allows for `-sSOCKETS_DEBUG -sRUNTIM_DEBUG=0` to opt out of the `RUNTIME_DEBUG` channel. Finally, disable the `RUNTIME_DEBUG` traces that occur during turns of the event loop unless `RUNTIME_DEBUG` is set to 2. This avoids flooding the console will messages in applications that are using the event loop.
sbc100
force-pushed
the
test_sdl_key_test
branch
from
196d3f3
to
9993844
Compare
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
) Also, test_sdl_key_test.c to test_interactive.py. This test was not being run anywhere else and serves as simple way to test/debug keyboard events. Also, only set the `RUNTIME_DEBUG` default if the user does not explicitly set it themselves. This allows for `-sSOCKETS_DEBUG -sRUNTIM_DEBUG=0` to opt out of the `RUNTIME_DEBUG` channel. Finally, disable the `RUNTIME_DEBUG` traces that occur during turns of the event loop unless `RUNTIME_DEBUG` is set to 2. This avoids flooding the console will messages in applications that are using the event loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, test_sdl_key_test.c to test_interactive.py. This test was not being run anywhere else and serves as simple way to test/debug keyboard events.
Also, only set the
RUNTIME_DEBUGdefault if the user does not explicitly set it themselves. This allows for-sSOCKETS_DEBUG -sRUNTIM_DEBUG=0to opt out of theRUNTIME_DEBUGchannel.Finally, disable the
RUNTIME_DEBUGtraces that occur during turns of the event loop unlessRUNTIME_DEBUGis set to 2. This avoids flooding the console will messages in applications that are using the event loop.