[ASYNCIFY] Add some assertions. NFC #24332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
asyncify_assertion
branch
from
2657eb3 to
b5d8bc9
Compare
kripken
approved these changes
May 15, 2025
|
@kripken what do you think about the assertion firing in |
sbc100
force-pushed
the
asyncify_assertion
branch
from
b5d8bc9 to
56627e0
Compare
|
Hmm, that sounds like a bug... why is it trying to create a rewind function for a non-existing export? I'd expect it to create them when it actually needs them. Perhaps somewhere in the code has a hardcoded assumption about main always existing? |
sbc100
force-pushed
the
asyncify_assertion
branch
from
56627e0 to
02d1d28
Compare
|
Ah, I had the assertion in slightly the wrong place. All good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.