[MODULARIZE=instance] Mark MINIMAL_RUNTIME as not supported #24344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
May 15, 2025
sbc100
force-pushed
the
modularize_instance_more
branch
2 times, most recently
from
e000d59 to
59dba38
Compare
sbc100
added a commit
that referenced
this pull request
May 16, 2025
This was duplicated in quite a few places and slightly different in some places. This change reduces that size of the code a little and reduces the number of places we specify it to just two. This change also fixes the `instance.test_environment` test which was failing due to broken nodejs detection in shell.js (it was checking for `require` which doesn't exist in ES module mode). Split out from #24344
sbc100
force-pushed
the
modularize_instance_more
branch
from
59dba38 to
3257e01
Compare
|
PTAL, this is now rebased on top of #24354 and all tests are now passing on the modularize-instance bot |
Also disable a bunch of unsupported tests. Now we can run the entire core test in MODULARIZE=instance mode! I'm adding a new test running here, which we might not want to keep around forever, but its very useful while working on ESM integration.
sbc100
force-pushed
the
modularize_instance_more
branch
from
3257e01 to
d8bf490
Compare
dschuff
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disable a bunch of unsupported tests.
Now we can run the entire core test in MODULARIZE=instance mode! I'm adding a new test running here, which we might not want to keep around forever, but its very useful while working on ESM integration.