-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[AUDIO_WORKLET] Add support for MEMORY64 with 2GB and 4GB heap #24732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
These failing size related tests are unrelated to the changes:
They don't fail for me with Emscripten 4.0.12 built from The failing |
To successfully rebaseline codesize tests on main you need to first run For pre-existing codesize changes we have a bot that automatically updates them.. I'll trigger it now so that main is up-to-date. |
What's the difference between |
The The easiest way to use any emscripten checkout without emsdk binaries is to do set |
I think it’s a throwback from LLVM fixes we were doing, and it’s stuck. I’ll switch to |
Unrelated fails seem Chrome related, same as #24750 for example. (Re-run and passed) |
This pulls the changes out of #23508 to add just the
MEMORY64
support.The already merged interactive tests (from #23659) can be run with:
The browser tests with wasm64 have been re-enabled.
Note: the intention is to add the performance improvements (from last October) once this is merged (which are still relevant and produce the same improvements).
Will need a once-over when #24734 lands.