[AUDIO_WORKLET] Add support for MEMORY64 with 2GB and 4GB heap #24732

cwoffenden · 2025-07-17T14:21:39Z

This pulls the changes out of #23508 to add just the MEMORY64 support.

The already merged interactive tests (from #23659) can be run with:

test/runner.py interactive_2gb.test_audio_worklet_params_mixing
test/runner.py interactive64_4gb.test_audio_worklet_params_mixing

The browser tests with wasm64 have been re-enabled.

Note: the intention is to add the performance improvements (from last October) once this is merged (which are still relevant and produce the same improvements).

Will need a once-over when #24734 lands.

src/lib/libwebaudio.js

cwoffenden · 2025-07-21T10:11:57Z

These failing size related tests are unrelated to the changes:

test_minimal_runtime_code_size_hello_webgl_wasm2js
test_minimal_runtime_code_size_hello_webgl_wasm
test_minimal_runtime_code_size_hello_webgl2_wasm2js
test_minimal_runtime_code_size_hello_webgl2_wasm

They don't fail for me with Emscripten 4.0.12 built from sdk-main-64bit.

The failing test_codesize_hello_dylink_all is fixed in #24742.

sbc100 · 2025-07-21T18:53:15Z

These failing size related tests are unrelated to the changes:
test_minimal_runtime_code_size_hello_webgl_wasm2js
test_minimal_runtime_code_size_hello_webgl_wasm
test_minimal_runtime_code_size_hello_webgl2_wasm2js
test_minimal_runtime_code_size_hello_webgl2_wasm
They don't fail for me with Emscripten 4.0.12 built from sdk-main-64bit.

The failing test_codesize_hello_dylink_all is fixed in #24742.

To successfully rebaseline codesize tests on main you need to first run emsdk install tot to ensure you have the very latest llvm + binaryen running.

For pre-existing codesize changes we have a bot that automatically updates them.. I'll trigger it now so that main is up-to-date.

cwoffenden · 2025-07-21T19:41:56Z

To successfully rebaseline codesize tests on main you need to first run emsdk install tot to ensure you have the very latest llvm + binaryen running.

What's the difference between tot and sdk-main-64bit? I've always used sdk-main-64bit because I can quickly switch between Emscripten's origin (main in the repo) and my own remote's branch.

sbc100 · 2025-07-21T19:58:20Z

To successfully rebaseline codesize tests on main you need to first run emsdk install tot to ensure you have the very latest llvm + binaryen running.

What's the difference between tot and sdk-main-64bit? I've always used sdk-main-64bit because I can quickly switch between Emscripten's origin (main in the repo) and my own remote's branch.

tot is like 4.0.10 in that installs pre-built binaries from our build servers (https://ci.chromium.org/p/emscripten-releases/g/main/console)

sdk-main-64bit is not used my many folks, it builds everything from source (which most ppl don't want to do). I think it updates the main branch each time its run but I don't remember for sure.

The tot binaries are what the emscripten CI tests run against.

The easiest way to use any emscripten checkout without emsdk binaries is to do set EM_CONFIG=/path/to/emsdk/.emscripten. Then you can do a git checkout of emscripten and run ./emcc ... and the emscripten checkout will use llvm and binaryen binaries from emsdk. See https://emscripten.org/docs/tools_reference/emsdk.html#how-do-i-use-my-own-emscripten-fork-with-the-sdk

cwoffenden · 2025-07-21T20:56:29Z

sdk-main-64bit is not used my many folks, it builds everything from source (which most ppl don't want to do).

I think it’s a throwback from LLVM fixes we were doing, and it’s stuck. I’ll switch to tot.

cwoffenden · 2025-07-22T08:50:56Z

Unrelated fails seem Chrome related, same as #24750 for example.

(Re-run and passed)

cwoffenden · 2025-07-30T12:56:01Z

@sbc100 Any chance of a review of this? It's a shorter replacement for the earlier one, discussed here way back when:

#23508 (comment)

sbc100 · 2025-07-21T18:55:01Z

src/lib/libwebaudio.js

+    var audioParams = [],
+      processorName = UTF8ToString({{{ makeGetValue('options', C_STRUCTS.WebAudioWorkletProcessorCreateOptions.name, '*') }}}),
+      numAudioParams = {{{ makeGetValue('options', C_STRUCTS.WebAudioWorkletProcessorCreateOptions.numAudioParams, 'i32') }}},
+      audioParamDescriptors = {{{ makeGetValue('options', C_STRUCTS.WebAudioWorkletProcessorCreateOptions.audioParamDescriptors, '*') }}},
      i = 0;


Can we convert to one-line-per-declaration here? I think it would help make this more readable, and should not effect minified code size.

Happily - I just followed the original style.

src/lib/libwebaudio.js

sbc100 · 2025-07-30T16:22:28Z

src/audio_worklet.js

-      this.callback = getWasmTableEntry(opts.callback);
-      this.userData = opts.userData;
+      this.callback = getWasmTableEntry({{{ toIndexType("opts.callback") }}});
+      this.userData = {{{ toIndexType("opts.userData") }}};


This second line doesn't look quite right to me.

userData I assume is a pointer, which means it should be Number and not a bigint (it should be converted to a Number when it first arrived on the JS side).

If it needs to be converted back to a pointer (i64) when this.callback then you should be using to64 at the callback call side, and not here.

toIndexType should only be used for places where you are direclty accessing the table, or the memory bounds.

Can you test with -sMEMORY64=2 as well perhaps to catch these cases where there is difference between to64 and toIndexType?

Yes, it's to convert it back to a pointer. It's constant, so I removed the need to keep doing the conversion.

I can test with -sMEMORY64=2 and put the conversions near the call.

src/lib/libwebaudio.js

sbc100 · 2025-07-30T16:25:38Z

(Probably not worth adding a -sMEMORY64=2 mode actually.. although maybe test locally with it?

The convention for JS library code is to use var for better minification. The use of `void 0` instead of `undefined` I believe is a minor code size optimization, but its somewhat obscure and (as you can see from the fact that the code expectations didn't change) it an optimization that is already performed on the generated code anyway. Split out from emscripten-core#24732

The convention for JS library code is to use var for better minification. The use of `void 0` instead of `undefined` I believe is a minor code size optimization, but its somewhat obscure and (as you can see from the fact that the code expectations didn't change) it an optimization that is already performed on the generated code anyway. Split out from #24732

cwoffenden force-pushed the cw-aw-mem64 branch from 90bbe70 to e38afdb Compare July 17, 2025 14:21

cwoffenden commented Jul 17, 2025

View reviewed changes

src/lib/libwebaudio.js Show resolved Hide resolved

cwoffenden force-pushed the cw-aw-mem64 branch from 490ad61 to 7c08452 Compare July 19, 2025 16:50

cwoffenden force-pushed the cw-aw-mem64 branch from a7e3bb6 to 9cedb47 Compare July 21, 2025 19:38

cwoffenden added 7 commits July 22, 2025 10:34

Additional struct data

8153141

Initial work to playback audio

cb5f217

Outputs working

3d3d0e2

Params working

0804e5f

Re-enabled wasm64 tests

8872c6a

'let' breaks closure (when used with makeGetValue)

986ee87

Rebaseline audio test size (compressed is smaller, uncompressed larger)

bc161b5

cwoffenden force-pushed the cw-aw-mem64 branch from 9cedb47 to bc161b5 Compare July 22, 2025 08:34

Something to re-run CI

5fe41a5

cwoffenden mentioned this pull request Jul 27, 2025

[AUDIO_WORKLET] Added support for MEMORY64 and 2GB heap (including tests) #23508

Closed

sbc100 reviewed Jul 30, 2025

View reviewed changes

src/lib/libwebaudio.js Show resolved Hide resolved

sbc100 mentioned this pull request Jul 30, 2025

Use var and undefined in libwebaudio.js. NFC #24814

Merged

cwoffenden marked this pull request as draft July 31, 2025 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AUDIO_WORKLET] Add support for MEMORY64 with 2GB and 4GB heap #24732

[AUDIO_WORKLET] Add support for MEMORY64 with 2GB and 4GB heap #24732

Uh oh!

cwoffenden commented Jul 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

cwoffenden commented Jul 21, 2025 •

edited

Loading

Uh oh!

sbc100 commented Jul 21, 2025

Uh oh!

cwoffenden commented Jul 21, 2025

Uh oh!

sbc100 commented Jul 21, 2025 •

edited

Loading

Uh oh!

cwoffenden commented Jul 21, 2025

Uh oh!

cwoffenden commented Jul 22, 2025 •

edited

Loading

Uh oh!

cwoffenden commented Jul 30, 2025

Uh oh!

sbc100 Jul 21, 2025

Uh oh!

cwoffenden Jul 30, 2025

Uh oh!

Uh oh!

sbc100 Jul 30, 2025

Uh oh!

cwoffenden Jul 30, 2025

Uh oh!

Uh oh!

sbc100 commented Jul 30, 2025

Uh oh!

Uh oh!

[AUDIO_WORKLET] Add support for MEMORY64 with 2GB and 4GB heap #24732

Are you sure you want to change the base?

[AUDIO_WORKLET] Add support for MEMORY64 with 2GB and 4GB heap #24732

Uh oh!

Conversation

cwoffenden commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cwoffenden commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbc100 commented Jul 21, 2025

Uh oh!

cwoffenden commented Jul 21, 2025

Uh oh!

sbc100 commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwoffenden commented Jul 21, 2025

Uh oh!

cwoffenden commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwoffenden commented Jul 30, 2025

Uh oh!

sbc100 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

cwoffenden Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbc100 Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

cwoffenden Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbc100 commented Jul 30, 2025

Uh oh!

Uh oh!

cwoffenden commented Jul 17, 2025 •

edited

Loading

cwoffenden commented Jul 21, 2025 •

edited

Loading

sbc100 commented Jul 21, 2025 •

edited

Loading

cwoffenden commented Jul 22, 2025 •

edited

Loading