Add error handling for stderrno when errno is invalid #25762
Merged
+54
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Nov 10, 2025
google-yfyang
force-pushed
the
errno
branch
4 times, most recently
from
26b0edf to
6f0aa29
Compare
sbc100
reviewed
Nov 11, 2025
sbc100
reviewed
Nov 11, 2025
sbc100
reviewed
Nov 11, 2025
sbc100
reviewed
Nov 11, 2025
sbc100
reviewed
Nov 11, 2025
sbc100
approved these changes
Nov 11, 2025
Collaborator
|
It looks this does come at a codesize cost. It is a very small one so maybe fine. Can you run |
Collaborator
Author
Done. |
sbc100
reviewed
Nov 11, 2025
| "a.out.js": 245483, | ||
| "a.out.nodebug.wasm": 574056, | ||
| "total": 819539, | ||
| "a.out.nodebug.wasm": 573907, |
Collaborator
There was a problem hiding this comment.
How did this one get smaller?? Strange.
Collaborator
Author
There was a problem hiding this comment.
possibly heavy optimization takes the return "Unknown error" branch and avoids the more complicated
s = (char *)&errmsgstr + errmsgidx[e];?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to match llvm-libc's behavior when an invalid errno is specified.
When errno is specified as -1, for instance, the current behavior prints "Success". With this change, any invalid errno emits out "Unknown error %d".