Create recipe.yaml for simplejson #458
Conversation
|
Looking at the CI logs it doesn't look like anything is being built: |
| version: "{{ version }}" | ||
|
|
||
| build: | ||
| number: 0 |
There was a problem hiding this comment.
since there are some C part to this library:
https://github.com/simplejson/simplejson/blob/master/simplejson/_speedups.c
shouldn't we also add {{ compiler('c') }} as a build requirement (see https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#LL23C7-L23C26) or disable the speed ups with REQUIRE_SPEEDUPS to make it pure python.
There was a problem hiding this comment.
@proppy absolutely correct!
|
|
||
| build: | ||
| number: 0 | ||
|
|
There was a problem hiding this comment.
should we also get the test from the original conda-forge recipe? https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#L30-L38
There was a problem hiding this comment.
you need to add such tests in the form of a test_simplejson.py / test_<some_name>.py and test the imports there.
ie:
def test_imports():
import simplejson
import simplejson._speedups
|
|
||
| source: | ||
| - url: https://files.pythonhosted.org/packages/c0/5c/61e2afbe62bbe2e328d4d1f426f6e39052b73eddca23b5ba524026561250/simplejson-{{ version }}.tar.gz | ||
| sha256: 6277f60848a7d8319d27d2be767a7546bc965535b28070e310b3a9af90604a4c |
There was a problem hiding this comment.
missing about with license section, see: https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#L40-L53
|
|
||
| source: | ||
| - url: https://files.pythonhosted.org/packages/c0/5c/61e2afbe62bbe2e328d4d1f426f6e39052b73eddca23b5ba524026561250/simplejson-{{ version }}.tar.gz | ||
| sha256: 6277f60848a7d8319d27d2be767a7546bc965535b28070e310b3a9af90604a4c |
There was a problem hiding this comment.
missing about with license section, see: https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#L40-L53
This should fix #456